New nav, 2025 #234
Merged
New nav, 2025 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hem to the mobile menu acocrdion sections and should be very close to done
| @@ -0,0 +1,23 @@ | |||
| <% arrow_icon = '<i class="fa-arrow-right fas" aria-hidden="true"></i>'.html_safe %> | |||
There was a problem hiding this comment.
copilot is suggesting this.
<% arrow_icon = '<i class="fa-arrow-right fas" aria-hidden="true" aria-label="Arrow icon"></i>'.html_safe %> do we use this aria labels anywhere else?
There was a problem hiding this comment.
I added the label, but it feels a bit pointless. Not sure where i got the aria-hidden from. We dont use these much.
I added "logo" to the alt attr of logos.
|
i went through this with copilot, it did not have any meaningful suggestions other than perhaps more accurate aria-labels. Logos for example can have |
devpost-mzheng
approved these changes
Jan 31, 2025
…owns with the keyboard :( and improved the arrows on hover and focused states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.